Fixes a crash on calling TemplateUrlServiceFactory when main Activity is stopping #21328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyZhukovsky
added
CI/skip-macos-x64
SergeyZhukovsky
requested review from
deeppandya,
tapanmodh,
AlexeyBarabash and
samartnik
SergeyZhukovsky
commented
Dec 11, 2023
| @@ -803,7 +792,6 @@ public void initializeState() { | |||
| setLoadedFeed(false); | |||
| setComesFromNewTab(false); | |||
| setNewsItemsFeedCards(null); | |||
| BraveSearchEngineUtils.initializeBraveSearchEngineStates(getTabModelSelector()); | |||
There was a problem hiding this comment.
I moved it to finishNativeInitialization as it does native calls inside.
deeppandya
reviewed
Dec 11, 2023
| if (profile != null && profile.isOffTheRecord()) { | ||
| // Set normal DSE as an active DSE when brave goes in background | ||
| // because currently set DSE is used by outside of brave(ex, brave search widget). | ||
| BraveSearchEngineUtils.updateActiveDSE(profile); |
There was a problem hiding this comment.
@SergeyZhukovsky are we okay removing the change here ?
There was a problem hiding this comment.
I verified such steps:
- Set standard tab SE to Brave.
- Set private tab SE to Qwant.
- Made some search on both and made sure they are correct.
- Switched to Private tab, closed Brave.
- Added a search widget.
- Tried to search via widget and made sure Brave SE is used in a standard tab is used for that.
Do you have other steps or do you know why we added the above?
There was a problem hiding this comment.
I didn't see any reason why it's there, but I'll keep an eye what happens once the change hits users.
There was a problem hiding this comment.
can you verify the change with quick action search widget we have ?
Steps :
- add widget on then home screen
- open brave app and change search engine from Brave to something else.
- Minimize the app and check widget, if it shows the write search engine on the url bar.
If above looks good, we are good to go ahead with the change.
There was a problem hiding this comment.
Screen_recording_20231211_152350.webm
AlexeyBarabash
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#34826
It's an attempt to fix the issue. I couldn't find any reason why we had that code, search widget works fine, it always uses a standard tab search engine even though we can set a different one for private tabs.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
there is none.